4617681: constructor of BufferedImage throws unexpected IllegalArgumentException #27640
+185
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
openjdk
bot
added
csr
mrserb
reviewed
Oct 6, 2025
| * not greater than zero. | ||
| * @throws IllegalArgumentException if the multiplication product of | ||
| * {@code width}, {@code height}, and the number of samples per pixel | ||
| * for the specified format exceeds the maximum length of a Java array. |
There was a problem hiding this comment.
This check seems too strict. It is possible to implement a BufferedImage that splits its internal data into multiple surfaces/arrays. It might be better to phrase this as optional:
“for the specified format exceeds the maximum supported length”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the behaviour of BufferedImage constructors for invalid dimensions is long overdue.
The behaviour for image types and sizes <= 0 is unchanged by this PR.
Also in many cases the behaviour for sizes that are too large is also unchanged.
In some cases, the behaviour is changed from "accidental" NegativeArraySizeException to a consistent IllegalArgumentException.
In no case is anything changed that would affect the possibility to construct a BufferedImage.
A test is provided to ensure the behaviour.
A CSR is provided too : https://bugs.openjdk.org/browse/JDK-8369155
Progress
Warning
4617681: constructor of BufferedImage throws unexpected IllegalArgumentExceptionIssues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27640/head:pull/27640$ git checkout pull/27640Update a local copy of the PR:
$ git checkout pull/27640$ git pull https://git.openjdk.org/jdk.git pull/27640/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27640View PR using the GUI difftool:
$ git pr show -t 27640Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27640.diff
Using Webrev
Link to Webrev Comment